Skip to content

Code Review

Mandatory standards

  • Meaningful changes require review before merge or release unless an approved exception exists
  • Reviewers should focus on correctness, maintainability, security, observability, and product impact
  • Authors should make review easy by keeping changes coherent and well described

Review expectations

A good review checks:

  • Does the change do what it claims?
  • Does it respect PMP-001 architecture boundaries?
  • Does it follow PMP-002 engineering standards?
  • Are tests and validation sufficient?
  • Are security or operational concerns introduced?
  • Keep review comments specific and actionable
  • Favor small reviews over large ones
  • Include validation notes when they help the reviewer understand risk